Ignore Errors When Dropping External Column
AbandonedPublic

Authored by narvaez on Sep 7 2017, 3:48 AM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Summary

This query can very fail if the table was first created on a relatively
new version of Akonadi.

Test Plan

I did not test this, but it cannot be more broken than the
original change.

Diff Detail

Repository
R165 Akonadi
Branch
external_column
Lint
No Linters Available
Unit
No Unit Test Coverage
narvaez created this revision.Sep 7 2017, 3:48 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 7 2017, 3:48 AM
dvratil requested changes to this revision.Sep 7 2017, 7:55 AM

This will mess up your data horribly if you continue running Akonadi without those queries executed.

Do you have a bug report about the problem? Which SQL backends it affects and what are the query errors? Why would it fail if the table was newly created ?

This revision now requires changes to proceed.Sep 7 2017, 7:55 AM

Do you have a bug report about the problem?

No.

Which SQL backends it affects and what are the query errors?

It happened to me in MariaDB.

Why would it fail if the table was newly created ?

Technically, IIUC if you installed Akonadi from master after 859382 you would not have that column. In practice, I think that was not what hapenned to me since I just realized 859382 was not included in applications 17.04. So I am not sure how did I end up in a situation where I did not have that column.

Technically, IIUC if you installed Akonadi from master after R859382 you would not have that column.

Akonadi will automatically create all missing tables, columns, and indices on start if they are missing - so the question is not why you did not have the column, but how is it possible that the revision 35 upgrade was executed on your system, if you did not have the commit that introduced it (which was also R165:859382)

Akonadi will automatically create all missing tables, columns, and indices on start if they are missing - so the question is not why you did not have the column, but how is it possible that the revision 35 upgrade was executed on your system, if you did not have the commit that introduced it (which was also R165:859382)

You are correct, I was not reading the log properly. I will drop this change then.

narvaez abandoned this revision.Sep 17 2017, 4:23 PM