Implement rasterized printing with QPrinter with hidden annotations
ClosedPublic

Authored by sander on Sep 4 2017, 2:55 PM.

Details

Summary

Previously, rasterized printing would use the QPrinter backend whenever annotations were to be printed, and fall back to the convert-to-ps toolchain otherwise. Effectively, this meant that printing on windows without showing the annotations was not possible (because on windows only the QPrinter can be used for printing).

However, there is a pending poppler patch at

https://bugs.freedesktop.org/show_bug.cgi?id=102513

that allows to disable annotation rendering for the renderToImage and renderToPainter methods that are used by QPrinter. This patch makes use of this new option, making printing on windows without annotations possible.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sander created this revision.Sep 4 2017, 2:55 PM
Restricted Application added a project: Okular. · View Herald TranscriptSep 4 2017, 2:55 PM
aacid added a subscriber: aacid.Sep 4 2017, 9:57 PM

HAVE_POPPLER_0_60 doesn't get defined anywhere ;)

See generators/poppler/CMakeLists.txt

sander updated this revision to Diff 19240.Sep 6 2017, 3:50 PM

Indeed. I was somehow expecting this to happen automatically. :-)

aacid accepted this revision.Sep 6 2017, 7:20 PM
This revision is now accepted and ready to land.Sep 6 2017, 7:20 PM
This revision was automatically updated to reflect the committed changes.