Differential D763

[GCI] Add "copy filename" action to context menu in tabs.
ClosedPublic
Actions

Authored by ematirov on Jan 8 2016, 6:54 PM.

Details

Reviewers
kfunk
Commits
R33:7a06e635076b: [GCI] Add "copy filename" action to context menu in tabs.
R32:7a06e635076b: [GCI] Add "copy filename" action to context menu in tabs.
Summary

Implements BUG: 341352

Test Plan

Tests passed. Action works as expected.

Diff Detail

Repository
R33 KDevPlatform
Branch
copy-filename-feature
Lint
No Linters Available
Unit
No Unit Test Coverage
ematirov updated this revision to Diff 1792.Jan 8 2016, 6:54 PM
ematirov retitled this revision from to [GCI] Add "copy filename" action to context menu in tabs..
ematirov updated this object.
ematirov edited the test plan for this revision. (Show Details)
ematirov added a reviewer: kfunk.
ematirov added a subscriber: kdevelop-devel.
ematirov updated this revision to Diff 1793.Jan 8 2016, 6:58 PM
ematirov added a project: KDevelop.

Remove unneeded whitespace change

kfunk added inline comments.Jan 8 2016, 7:05 PM
sublime/container.cpp
592 ↗(On Diff #1793)

qobject_cast please

kfunk added inline comments.Jan 8 2016, 7:06 PM
sublime/container.cpp
554 ↗(On Diff #1793)

Nitpick: Indent off, i18n should be below QIcon

ematirov updated this revision to Diff 1795.Jan 8 2016, 7:16 PM
kfunk accepted this revision.Jan 8 2016, 7:23 PM
kfunk edited edge metadata.

Well, great work again.

Thanks. Will push.

This revision is now accepted and ready to land.Jan 8 2016, 7:23 PM
Closed by commit R33:7a06e635076b: [GCI] Add "copy filename" action to context menu in tabs. (authored by ematirov, committed by kfunk). · Explain WhyJan 8 2016, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msublime/container.cpp (12 lines)

Diff 1795

View Options

sublime/container.cpp

Loading...