Don't reload from kritarc when generating a layer thumbnail or painting a QPainter canvas
ClosedPublic
Actions

Authored by nicholasl on Aug 29 2017, 3:36 PM.

Details

Reviewers

Group Reviewers

Commits

R37:1da3b038dcd8: Don't reload from kritarc when generating a layer thumbnail or painting a…
R37:e97f50912718: Don't reload from kritarc when generating a layer thumbnail or painting a…

Summary

Question
In the prototype of KisCoordinatesConverter::getQPainterCheckersInfo(), scrollCheckers is not defined as const, whereas the implementation has it as const.
The same situation exists in the function getOpenGLCheckersInfo(), which is not modified by this patch.
Should the prototypes be made to match the implementations?

Diff Detail

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicholasl created this revision.Aug 29 2017, 3:36 PM

Restricted Application added a subscriber: woltherav. · View Herald TranscriptAug 29 2017, 3:36 PM

Accepted, and, yes, the prototype should always match the implementation.

This revision is now accepted and ready to land.Aug 30 2017, 7:36 AM

Closed by commit R37:e97f50912718: Don't reload from kritarc when generating a layer thumbnail or painting a… (authored by nicholasl). · Explain WhyAug 31 2017, 7:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libs/ui/KisNodeDelegate.h (3 lines)
M			libs/ui/KisNodeDelegate.cpp (24 lines)
M			libs/ui/canvas/kis_coordinates_converter.h (3 lines)
M			libs/ui/canvas/kis_coordinates_converter.cpp (6 lines)
M			libs/ui/canvas/kis_qpainter_canvas.cpp (7 lines)