Differential D760

Fix default fallback for Sublime::View.
ClosedPublic
Actions

Authored by cordlandwehr on Jan 8 2016, 9:01 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:259218d904bd: Fix default fallback for Sublime::View.
R33:259218d904bd: Fix default fallback for Sublime::View.
Summary

Fix startup crash of KDevelop by using an existing view instead of a
list index that cannot exist.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr updated this revision to Diff 1783.Jan 8 2016, 9:01 AM
cordlandwehr retitled this revision from to Fix default fallback for Sublime::View..
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 8 2016, 9:01 AM
kfunk accepted this revision.Jan 8 2016, 10:21 AM
kfunk added a reviewer: kfunk.
kfunk added subscribers: Sergobot, kfunk.

Ouch. LGTM.

@Sergobot: Was that change done by Clazy or did you manually turn back() in to area->views().at(area->views().size()? If the former is the case, please do report a bug in Clazy.

Thanks!

This revision is now accepted and ready to land.Jan 8 2016, 10:21 AM
Closed by commit R33:259218d904bd: Fix default fallback for Sublime::View. (authored by cordlandwehr). · Explain WhyJan 8 2016, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/workingsets/workingset.cpp (2 lines)

Diff 1784

View Options

shell/workingsets/workingset.cpp

Loading...