Differential D756

[GCI] Windows support: Parse MSVC compile errors
AbandonedPublic
Actions

Authored by kfunk on Jan 7 2016, 8:41 PM.

Details

Reviewers
itatriev
Group Reviewers
KDevelop
Maniphest Tasks
T602: Windows: Output filtering, make sure basic warnings/errors from MSVC are captured
Summary

This is related to T602.

Must state that is was done with huge support from Kevin Funk. Thanks, Kevin.

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
itatriev updated this revision to Diff 1775.Jan 7 2016, 8:41 PM
itatriev retitled this revision from to [GCI] Windows support: Parse MSVC compile errors.
itatriev updated this object.
itatriev edited the test plan for this revision. (Show Details)
itatriev added a reviewer: KDevelop.
itatriev set the repository for this revision to R33 KDevPlatform.
itatriev added a project: KDevelop.
itatriev added a subscriber: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 7 2016, 8:41 PM
kfunk accepted this revision.Jan 7 2016, 10:38 PM
kfunk added a reviewer: kfunk.
kfunk added a task: T602: Windows: Output filtering, make sure basic warnings/errors from MSVC are captured.
kfunk added a subscriber: kfunk.

Fix, then submit.

In the commit message, use: "Fixes T602"

Thanks!

outputview/outputfilteringstrategies.cpp
254

move to start of line

257

dito

This revision is now accepted and ready to land.Jan 7 2016, 10:38 PM
kfunk commandeered this revision.Jan 8 2016, 3:57 PM
kfunk edited reviewers, added: itatriev; removed: kfunk.
This revision now requires review to proceed.Jan 8 2016, 3:57 PM
kfunk abandoned this revision.Jan 8 2016, 3:58 PM

Pushed:

commit cdefbe5823dea73279057dfe4f6318a71be129fd
Author: Imran Tatriev <itatriev@gmail.com>
Date: Fri Jan 8 02:38:04 2016 +0600

Parse MSVC compile errors
Fixes T602

(cherry picked from commit 7a9bf29dbc08a04a07488a43b35a39d32fa4e3ae)

Revision Contents
Changeset List

Diff 1775

View Options

outputview/outputfilteringstrategies.cpp

Loading...
View Options

outputview/tests/test_filteringstrategy.cpp

Loading...