Differential D7542

[Notifications Applet] Don't explicitly set Plasmoid.icon
ClosedPublic
Actions

Authored by broulik on Aug 25 2017, 1:47 PM.

Tags

Subscribers

davidedmundson, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R120:1b56c4b7a925: [Notifications Applet] Don't explicitly set Plasmoid.icon

Summary

We have a custom compact representation anyway.
All it does is change the tooltip icon but more importantly break the notification icon in System Tray settings.

BUG: 375093

Test Plan

Icon shows up in System Tray settings fine now
Tooltip now always shows the "blue" icon but that's fine I guess
The system tray notification icon itself works as before

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Aug 25 2017, 1:47 PM

Restricted Application added a project: Plasma. · View Herald TranscriptAug 25 2017, 1:47 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik edited the summary of this revision. (Show Details)Aug 25 2017, 1:47 PM

Good stuff

This revision is now accepted and ready to land.Aug 25 2017, 1:48 PM

Closed by commit R120:1b56c4b7a925: [Notifications Applet] Don't explicitly set Plasmoid.icon (authored by broulik). · Explain WhyAug 25 2017, 1:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/notifications/package/contents/ui/main.qml (7 lines)

Diff 18754

applets/notifications/package/contents/ui/main.qml

Loading...