Differential D7541

kdepim-runtime: use the new KF5::kimaptest target variable
ClosedPublic
Actions

Authored by winterz on Aug 25 2017, 1:44 PM.

Details

Reviewers
dvratil
mlaurent
Commits
R44:91c1f14eb989: use the new KF5::kimaptest target variable
Summary

use the new KF5::kimaptest variable

Test Plan

builds ok

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Aug 25 2017, 1:44 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 25 2017, 1:44 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
dvratil requested changes to this revision.Aug 25 2017, 2:16 PM

KF5::kimaptest is only available if KIMAP is compiled with -DBUILD_TESTING, so you need to keep the whole thing wrapped in a conditional - if (TARGET KF5::kimaptest) should do.

This revision now requires changes to proceed.Aug 25 2017, 2:16 PM
winterz updated this revision to Diff 18842.Aug 27 2017, 2:55 PM
winterz edited edge metadata.

updated revision that which ensures the kimaptest library was built in kimap project.

dvratil accepted this revision.Aug 27 2017, 3:29 PM

Make sure to bump minimum required KIMAP version to 5.6.41 before committing.

This revision is now accepted and ready to land.Aug 27 2017, 3:29 PM
Closed by commit R44:91c1f14eb989: use the new KF5::kimaptest target variable (authored by winterz). · Explain WhyAug 27 2017, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18849

View Options

CMakeLists.txt

Loading...
View Options

resources/imap/autotests/CMakeLists.txt

Loading...