Differential D7467

Check item validity before using it
ClosedPublic
Actions

Authored by leinir on Aug 22 2017, 4:10 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:e0f56dac7959: Check item validity before using it
Summary

itemAt isn't guaranteed to always return an item, so check the validity of that first before trying to do things with it.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Aug 22 2017, 4:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptAug 22 2017, 4:10 PM
leinir abandoned this revision.Aug 22 2017, 4:20 PM

Closed by: https://commits.kde.org/kirigami/6dffeef3c09ef62f7ea2775bf9ec72585755e3d2

(sorry, the commit missed an l so the hook failed, and i can't close it submitted without that hook, and force pushing a new thing just seems... not very nice)

leinir reclaimed this revision.Aug 22 2017, 4:20 PM

Also, i am a silly person and closed the wrong revision.

mart accepted this revision.Aug 22 2017, 4:26 PM
This revision is now accepted and ready to land.Aug 22 2017, 4:26 PM
Closed by commit R169:e0f56dac7959: Check item validity before using it (authored by leinir). · Explain WhyAug 22 2017, 4:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18545

View Options

src/controls/templates/OverlayDrawer.qml

Loading...