Honour layer position for isCurrentPage
ClosedPublic

Authored by leinir on Aug 22 2017, 2:37 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Summary

If using layers, isCurrentPage would without this patch potentially be conceptually true for more than one page at a time, but in fact only true for the current page of the PageRow, and not the page in the layer currently on top. This seems awkward and seems perhaps unintended, so, this patch makes isCurrentPage honour layers as well as the PageRow itself.

Diff Detail

Repository
R169 Kirigami
Lint
Lint Skipped
Unit
Unit Tests Skipped
leinir created this revision.Aug 22 2017, 2:37 PM
Restricted Application added a subscriber: plasma-devel. ยท View Herald TranscriptAug 22 2017, 2:37 PM
mart accepted this revision.Aug 22 2017, 2:44 PM

good catch!

This revision is now accepted and ready to land.Aug 22 2017, 2:44 PM
leinir closed this revision.Aug 22 2017, 4:21 PM

Closed by: https://commits.kde.org/kirigami/6dffeef3c09ef62f7ea2775bf9ec72585755e3d2

(sorry, the commit missed an l so the hook failed)