Differential D745

Fix some nested xi18n call
ClosedPublic
Actions

Authored by elvisangelaccio on Jan 5 2016, 2:56 PM.

Details

Reviewers
rthomsen
Summary

xi18n calls cannot be nested, otherwise the markup gets messed up.
Plugins should use kxi18n instead, but that returns a
KLocalizedString which is not a QString and would require us to change the
ArchiveInterface API.

So an easier solution is to not use xi18n from the plugins. This patch fixes some
of the most common used among these nested calls.

Task T926

Diff Detail

Repository
R36 Ark
Branch
fix-plugins-xi18nc
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 1751.Jan 5 2016, 2:56 PM
elvisangelaccio retitled this revision from to Fix some nested xi18n call.
elvisangelaccio updated this object.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJan 5 2016, 2:56 PM
rthomsen added inline comments.Jan 9 2016, 12:28 PM
plugins/libarchive/libarchivehandler.cpp
179

You are still using markup here. Won't the tags be visible?

elvisangelaccio added inline comments.Jan 10 2016, 10:20 AM
plugins/libarchive/libarchivehandler.cpp
179

It looks like the ExtractJob's errors are never shown inside a xi18n() call. So in this case there should be no nesting.

rthomsen accepted this revision.Jan 14 2016, 6:39 PM
rthomsen edited edge metadata.

Ship it! :)

This revision is now accepted and ready to land.Jan 14 2016, 6:39 PM
elvisangelaccio closed this revision.Jan 14 2016, 7:02 PM
elvisangelaccio marked 2 inline comments as done.

Revision Contents
Changeset List

Diff 1751

View Options

plugins/libarchive/libarchivehandler.cpp

Loading...