Move X11 specific event filtering for ScreenEdges into x11 standalone platform
ClosedPublic
Actions

Authored by graesslin on Aug 19 2017, 9:01 AM.

Details

Reviewers

None

Group Reviewers

KWin
Plasma

Commits

R108:833f933c5c6a: Move X11 specific event filtering for ScreenEdges into x11 standalone platform

Summary

This change splits out the X11 specific event filtering into a dedicated
X11EventFilter. It is created in the x11 standalone platform plugin when
the first Edge is being created.

Some of the X11 specific code is removed from ScreenEdges, though more
refactoring is possible in ScreenEdges to share more code between X11
specific and generic implementation.

Test Plan

Run KWin on Xephyr, screen edge approach effect still shows

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Aug 19 2017, 9:01 AM

Restricted Application added a project: KWin. · View Herald TranscriptAug 19 2017, 9:01 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependency: D7395: [tabBox] Move X11 specific event filtering into a dedicated event filter.Aug 19 2017, 9:01 AM

Closed by commit R108:833f933c5c6a: Move X11 specific event filtering for ScreenEdges into x11 standalone platform (authored by graesslin). · Explain WhySep 1 2017, 3:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/test_screen_edges.cpp (55 lines)
M		events.cpp (16 lines)
M		plugins/platforms/x11/standalone/CMakeLists.txt (1 line)
A	M	plugins/platforms/x11/standalone/screenedges_filter.h (37 lines)
A	M	plugins/platforms/x11/standalone/screenedges_filter.cpp (65 lines)
M		plugins/platforms/x11/standalone/x11_platform.h (2 lines)
M		plugins/platforms/x11/standalone/x11_platform.cpp (4 lines)
M		screenedge.h (13 lines)
M		screenedge.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18378	b4efeeb		Aug 19 2017, 9:01 AM	★	★
Diff 2	19054	76ee471	R108:833f933c5c6aa1bedfb57fa65bf7d9b6e2f9516a	Sep 1 2017, 3:01 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
6f22770228a4	4aca7a83ab20	b4efeeb56ca5	Martin Flöser	Move X11 specific event filtering for ScreenEdges into x11 standalone platform (Show More…)	Aug 19 2017, 8:58 AM

Status	Author	Revision
Closed	graesslin	D7406 Move X11 specific event filtering for ScreenEdges into x11 standalone platform
Closed	graesslin	D7395 [tabBox] Move X11 specific event filtering into a dedicated event filter
Closed	graesslin	D7374 Move X11 movingClient handling into a dedicated X11EventFilter
Closed	graesslin	D7371 Create a dedicated X11EventFilter for recognizing first user interaction