Differential D737

[GCI] Remember Filesystems ToolView's location in session
ClosedPublic
Actions

Authored by kfunk on Jan 4 2016, 9:14 PM.

Details

Reviewers
mwolff
itatriev
Group Reviewers
KDevelop
Summary

It's done.

P.S. Copyright changes look strange on Phabricator, but they are ok in text editors.

Test Plan

I've tested it with 3+ sessions - works fine for each session.

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
itatriev updated this revision to Diff 1733.Jan 4 2016, 9:14 PM
itatriev retitled this revision from to [GCI] Remember Filesystems ToolView's location in session.
itatriev updated this object.
itatriev edited the test plan for this revision. (Show Details)
itatriev added a reviewer: KDevelop.
itatriev set the repository for this revision to R33 KDevPlatform.
itatriev added a project: KDevelop.
itatriev changed the visibility from "Public (No Login Required)" to "KDevelop (Project)".
itatriev changed the edit policy from "All Users" to "KDevelop (Project)".
itatriev added a subscriber: KDevelop.
kfunk added a subscriber: kfunk.Jan 4 2016, 10:58 PM
kfunk added inline comments.
plugins/filemanager/filemanager.cpp
71

Not needed, let's just save this on exit.

102

Remove, not needed.

108

Just do the readEntry inside FileManager directly. No need to create an extra function.

itatriev updated this revision to Diff 1738.Jan 5 2016, 6:35 AM

That's it. I think this is exactly what you were talking about ;)

itatriev marked 3 inline comments as done.Jan 5 2016, 6:36 AM
mwolff accepted this revision.Jan 5 2016, 9:17 AM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm, but one minor cleanup could be done.

plugins/filemanager/filemanager.cpp
73

you could also use urlnav's URL here, no? to make sure they both use the same URL? I bet KUrlNavigator has some API to get its URL.

This revision is now accepted and ready to land.Jan 5 2016, 9:17 AM
itatriev updated this revision to Diff 1745.Jan 5 2016, 9:27 AM
itatriev edited edge metadata.
itatriev marked an inline comment as done.
kfunk accepted this revision.Jan 5 2016, 9:40 AM
kfunk added a reviewer: kfunk.

Looks great, thanks.

Will push.

kfunk commandeered this revision.Jan 6 2016, 3:26 PM
kfunk closed this revision.
kfunk edited reviewers, added: itatriev; removed: kfunk.

Pushed:

commit 7a61a3f6ab890894441f3e05d5b51cc7817073a5
Author: Imran Tatriev <itatriev@gmail.com>
Date: Tue Jan 5 02:54:02 2016 +0600

Remember Filesystem ToolView's location in each session
kfunk edited edge metadata.EditedJan 6 2016, 10:14 PM
kfunk changed the visibility from "KDevelop (Project)" to "Public (No Login Required)".
kfunk changed the edit policy from "KDevelop (Project)" to "All Users".
kfunk added a subscriber: kdevelop-devel.

@itatriev: Please don't change the visibility/access rights when creating bugs. Best to just add the project .

The rest should be taken care of Arcanist: https://secure.phabricator.com/book/phabricator/article/arcanist_diff/ (I think you're not using it?)

Revision Contents
Changeset List

Diff 1745

View Options

plugins/filemanager/filemanager.h

Loading...
View Options

plugins/filemanager/filemanager.cpp

Loading...