Differential D7332

Port primary combo box to QComboBox::activated
ClosedPublic
Actions

Authored by davidedmundson on Aug 15 2017, 3:43 PM.

Details

Reviewers
sebas
Group Reviewers
Plasma
Summary

Get rid of a bunch of blockSignals calls

Test Plan

Started up, apply button initial state still disabled
Changed value. Was fine

Diff Detail

Repository
R104 KScreen
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Aug 15 2017, 3:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 15 2017, 3:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Aug 15 2017, 3:46 PM
sebas added a subscriber: sebas.

Nice.

This code is on its way out though, pending my forever-taking kscreen kcm rewrite. Since that's not going fast, I don't want to block progress on the currently shipped version.

Thanks!

This revision is now accepted and ready to land.Aug 15 2017, 3:46 PM
davidedmundson closed this revision.Aug 26 2017, 11:47 AM

Made diff against non-master

Revision Contents
Changeset List

PathPackages
Mkcm/src/widget.cpp (8 lines)

Diff 18198

View Options

kcm/src/widget.cpp

Loading...