I didn't feel like stubbing away that one for testing since it jumps
straight at QTemporaryFile and QDesktopServices here. Probably better to
keep it as a simple ten lines method in that case.
Details
Details
Diff Detail
Diff Detail
- Repository
- R4 Zanshin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/presentation/artifacteditormodel.cpp | ||
|---|---|---|
| 305 | Technically not leaked, but any long-running system that then crashes, will not delete all these tempfiles. I wonder what strategy KMail uses for viewing attachments, check with Laurent? BTW I have implemented a solution where the app itself deletes the tempfile after use, in some KDE apps. KRun's tempfile argument supports this, and fallsback to kioexec if the app doesn't support it, so a solution would be to use KRun instead of QDesktopServices. | |
| 306 | autoremove is on by default | |
| src/presentation/artifacteditormodel.cpp | ||
|---|---|---|
| 305 | I'm using the same strategy than KOrganizer here. Also, I'd rather stay away from KRun if I can... I wonder if there's any other mechanism which could be used to clean up the temp files. Note that most modern distros swipe /tmp regularly AFAIK. | |
Comment Actions
OpenSuSE doesn't appear to wipe /tmp. I have temporary files from 2016 in there ;)
But OK, if it's good enough for KOrganizer, we can leave it as that.