| mwolff |
| KDevelop |
A test in kdev-ruby fails, and the root problem is that
TestProjectController destroys some of the semantics of its
ProjectController base. ProjectController isn't able to delete projects
in such cases => leads to strange issues in the end.
Fix for good: Remove TestProjectController, and add a little more API to
IProject & IProjectController which we can access from unit tests.
Also leads to a cleaner implementation of
ProjectController::closeProject (no cast to Project* needed anymore).
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I'd prefer if we find a way to fix the code to have the separation in tact while fixing the bug. is this really not possible?
| interfaces/iprojectcontroller.h | ||
|---|---|---|
| 156 | b/c this is only used in testing environments we pushed this code into the test controller to separate the API and keep the public one as minimal as possible. can't we keep this in the test controller? | |
| interfaces/iprojectcontroller.h | ||
|---|---|---|
| 156 | Yep, I noticed it should be possible by coupling TestController closer to ProjectController. I'll recreate TestController, and move back addProject and takeProject. Rest is still useful in public interfaces; esp. IProject::close allows a cleaner implementation in ProjectController. Will also revert some of the changes in the unit tests. | |
the diff is strangely formatted, i.e. I only see the diff to previous, not the diff to master. is that just me?