| mlaurent | |
| aheinecke |
This change toggles the default behavior of composer and will always store drafts encrypted - but only if user has enabled encryption in the composer. If the "Encrypt" action is not enabled, the draft will not be stored encrypted.
This change also renames the option NeverEncryptDrafts to AlwaysEncryptDrafts to avoid the "double negative" when doing !cfg->neverEncryptDrafts. It's also a neat hack to get the same defaults for all users :-)
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
From my side thumbs up. I checked what Microsoft does in their S/MIME Outlook implementation and they Encrypt / Sign drafts by default (if encryption is selected). I think (but I'm not sure) Enigmail / Thunderbird does this, too.
| src/settings/kmail.kcfg.cmake | ||
|---|---|---|
| 177 | How do you manage to migrate settings ? | |
| src/settings/kmail.kcfg.cmake | ||
|---|---|---|
| 177 | This is the smart neat hack I mentioned :-) People who disabled "Never encrypt drafts" (i.e. people who enabled encryption) will have it still enabled with the new option, because "Always encrypt drafts" is enabled by default. People who had "Never encrypt drafts" enabled - the default value - will now get the new feature of encrypting drafts enabled by default - and that's the main point of this change - to enable to encrypt drafts by default. Most people did not know we had this feature anyway because it was off by default so we will now turn it on for them and if they will not like it, they can turn it off again in the settings. | |
| src/settings/kmail.kcfg.cmake | ||
|---|---|---|
| 177 | Ok I understand. | |