refactored project settings

Authored by schnere on Aug 7 2017, 9:48 AM.


Group Reviewers

refactored project settings - fixed: project settings configuration not working

Diff Detail

Lint Skipped
Unit Tests Skipped
schnere created this revision.Aug 7 2017, 9:48 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 7 2017, 9:48 AM
kfunk requested changes to this revision.Aug 7 2017, 10:00 AM
kfunk added a subscriber: kfunk.

A couple of notes -- the patch looks good in general, thanks!

This revision now requires changes to proceed.Aug 7 2017, 10:00 AM
schnere updated this revision to Diff 17817.Aug 7 2017, 10:10 AM
schnere edited edge metadata.

removed commented lines

Sorry, I wanted to review everything before uploading, but I saw that you were commiting a view changes and I wanted to save us both from double work...
I'll take a look at Arcanist, thanks for the hint.

kfunk added a comment.EditedAug 7 2017, 10:19 AM

Not a problem.

Arcanist is very easy to setup, if you don't want to bother with the documentation: Just try running arc diff when inside the kdev-upload directory and take it from there :)

schnere abandoned this revision.Aug 8 2017, 8:58 AM

Okay, added D7199 with arc now. Same patch content - so I'm closing this now...