refactored project settings - fixed: project settings configuration not working
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
A couple of notes -- the patch looks good in general, thanks!
- Please upload the changes with Arcanist: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist (also makes *your* life easier uploading patches)
- Please don't comment lines which were replaced in your diff, just remove them.
Comment Actions
Sorry, I wanted to review everything before uploading, but I saw that you were commiting a view changes and I wanted to save us both from double work...
I'll take a look at Arcanist, thanks for the hint.
Comment Actions
Not a problem.
Arcanist is very easy to setup, if you don't want to bother with the documentation: Just try running arc diff when inside the kdev-upload directory and take it from there :)