Documentation toolview: restore custom context menu on page view

Authored by kossebau on Aug 7 2017, 4:35 AM.



The widget wrapper added for hiding the implementation choice
between QWebEngine or QWebKit broke the custom context menu setting,
as any calls to set contextMenuPolicy of a StandardDocumentationView
object, like in QtHelpDocumentation::documentationWidget(), no longer
affected the web view itself.

This patch restores that (and ensures the basic custom menu also with
non-QtHelpDocumentation users of StandardDocumentationView, like by
plucings for man-pages or cmake).

The change from exposing copyAction() to createStandardContextMenu()
should allow extending the base menu (e.g. by find-text action)
without menu extending classes like QtHelpDocumentation having
to know about it.

Diff Detail

R33 KDevPlatform
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Aug 7 2017, 4:35 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 7 2017, 4:35 AM
apol accepted this revision.Aug 7 2017, 10:16 AM
apol added a subscriber: apol.

Thanks for looking into this! was meaning to for a while never got to it.

This revision is now accepted and ready to land.Aug 7 2017, 10:16 AM
This revision was automatically updated to reflect the committed changes.