Don't list() if we are creating a new archive from Ark window
ClosedPublic

Authored by elvisangelaccio on Dec 28 2015, 1:40 PM.

Details

Summary

Currently if we create a new archive using the New action, Ark creates a ListJob which is obviously going to fail, since the archive does not exist yet. Previously Ark would just ignore such failing jobs, but with Ark 15.12 the clirar plugin actually parses the error message of unrar as a valid comment (see attached screenshot).

We can solve the problem at the root and only run a ListJob if the archive to be listed actually exists.

Test Plan

Creating a new RAR archive using the New action, does not show anymore the unrar error message as comment.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Don't list() if we are creating a new archive from Ark window.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to R36 Ark.
elvisangelaccio added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptDec 28 2015, 1:40 PM

Screenshot of the unrar's error message displayed in the comment widget:

rthomsen accepted this revision.Jan 2 2016, 12:41 AM
rthomsen edited edge metadata.

Ship it! :)

This revision is now accepted and ready to land.Jan 2 2016, 12:41 AM
This revision was automatically updated to reflect the committed changes.