Differential D7114

Remove wrong additional check
ClosedPublic
Actions

Authored by dkurz on Aug 3 2017, 7:21 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Summary

The old second check prevented entering the if body if only the modifiedParts condition was true.

Diff Detail

Repository
R165 Akonadi
Lint
Lint Skipped
Unit
Unit Tests Skipped
dkurz created this revision.Aug 3 2017, 7:21 PM
dvratil requested changes to this revision.Aug 4 2017, 8:44 AM
dvratil added a subscriber: dvratil.
dvratil added inline comments.
src/server/handler/modify.cpp
200

I think the outer condition should remain and the inner one should be removed - looking into git history, that's how it was intended to be.

This revision now requires changes to proceed.Aug 4 2017, 8:44 AM
dkurz updated this revision to Diff 17701.Aug 4 2017, 11:10 AM
dkurz edited edge metadata.
dkurz retitled this revision from Remove useless check to Remove wrong additional check.
dkurz edited the summary of this revision. (Show Details)
dkurz marked an inline comment as done.Aug 4 2017, 11:21 AM
dvratil accepted this revision.Aug 4 2017, 11:34 AM

Thanks for the patch!

This revision is now accepted and ready to land.Aug 4 2017, 11:34 AM
dkurz closed this revision.Aug 10 2017, 4:07 PM

Revision Contents
Changeset List

PathPackages
Msrc/server/handler/modify.cpp (4 lines)

Diff 17701

View Options

src/server/handler/modify.cpp

Loading...