Differential D7048

Add a new helper to ease fetching by collection
ClosedPublic
Actions

Authored by ervin on Aug 1 2017, 8:52 PM.

Details

Reviewers
bensi
dfaure
franckarrecot
Commits
R4:b6fc5486a818: Add a new helper to ease fetching by collection

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Aug 1 2017, 8:52 PM
dfaure accepted this revision.Aug 2 2017, 7:36 AM
dfaure added inline comments.
src/akonadi/akonadilivequeryhelpers.cpp
119

range-for instead of foreach?

This revision is now accepted and ready to land.Aug 2 2017, 7:36 AM
ervin added inline comments.Aug 2 2017, 6:43 PM
src/akonadi/akonadilivequeryhelpers.cpp
119

I'll ignore that comment for now, we got foreach at plenty of places for historical reason, I'd rather do a one time porting in a further patch.

bensi accepted this revision.Aug 3 2017, 7:37 PM
Closed by commit R4:b6fc5486a818: Add a new helper to ease fetching by collection (authored by ervin). · Explain WhyAug 4 2017, 6:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17684

View Options

src/akonadi/akonadilivequeryhelpers.h

Loading...
View Options

src/akonadi/akonadilivequeryhelpers.cpp

Loading...
View Options

tests/units/akonadi/akonadilivequeryhelperstest.cpp

Loading...