Differential D7035

Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved
ClosedPublic
Actions

Authored by hein on Aug 1 2017, 1:07 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:a1e2ddd67a12: Fix group dialog no longer resizing/closing as windows are closed and the group…
Summary

Also delays the dialog resize until after the move transition ends
if there's going to be one, for a less jarring experience.

BUG:382638

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.8
Lint
No Linters Available
Unit
No Unit Test Coverage
hein created this revision.Aug 1 2017, 1:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 1 2017, 1:07 PM
broulik added a subscriber: broulik.Aug 1 2017, 1:13 PM
broulik added inline comments.
applets/taskmanager/package/contents/ui/GroupDialog.qml
138 ↗(On Diff #17491)

Unused

153 ↗(On Diff #17491)

count will already reflect the new count here? So essentially index == count means "the last item was removed"?

applets/taskmanager/package/contents/ui/TaskList.qml
23 ↗(On Diff #17491)

Unused?

hein updated this revision to Diff 17492.Aug 1 2017, 1:17 PM
hein marked an inline comment as done.

Cleanup from older version.

Sorry, got distracted by an IRC meeting.

hein updated this revision to Diff 17493.Aug 1 2017, 1:32 PM

Better code for closing on dissolve.

broulik accepted this revision.Aug 1 2017, 1:36 PM
This revision is now accepted and ready to land.Aug 1 2017, 1:36 PM
Closed by commit R119:a1e2ddd67a12: Fix group dialog no longer resizing/closing as windows are closed and the group… (authored by hein). · Explain WhyAug 1 2017, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17492

View Options

applets/taskmanager/package/contents/ui/GroupDialog.qml

Loading...
View Options

applets/taskmanager/package/contents/ui/TaskList.qml

Loading...