Differential D7029

[Notifications] Improve mouse handling
ClosedPublic
Actions

Authored by broulik on Aug 1 2017, 8:36 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:7e2a29b0b18a: [Notifications] Improve mouse handling
Summary
  • Make links clickable again
  • Don't pass visualParent to context menu as we already give it a position, fixes it being positioned incorrectly
  • Open context menu on press already like is done everywhere else
  • Give "Copy" the edit-copy icon
  • Deselect text after copying again, otherwise it stays selected but the user cannot unselect it.

BUG: 382263
FIXED-IN: 5.10.5

Test Plan
  • I can now click links in notifications again.
  • Verified that the clicked link is correct even when the notification area is scrollabe.
  • Context menu is positioned at mouse position now
  • Verified that default action is still triggered when no link is clicked

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 1 2017, 8:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 1 2017, 8:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this revision to Diff 17477.Aug 1 2017, 8:36 AM
broulik edited the test plan for this revision. (Show Details)

Removed debugging output

broulik edited the summary of this revision. (Show Details)Aug 1 2017, 8:37 AM
apol accepted this revision.Aug 1 2017, 10:43 AM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 1 2017, 10:43 AM
Closed by commit R120:7e2a29b0b18a: [Notifications] Improve mouse handling (authored by broulik). · Explain WhyAug 1 2017, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17482

View Options

applets/notifications/package/contents/ui/NotificationItem.qml

Loading...