fix plasmashell unsetting QSG_RENDER_LOOP
ClosedPublic

Authored by mkoller on Jul 26 2017, 9:15 PM.

Details

Summary

being hit by the problem of plasmashell using way too much CPU even when doing "nothing", I found
the description of the QSG_RENDER_LOOP env variable to be settable to basic, which solves the problem.
However, even though I set the var in ~/.config/plasma-workspace/env/KDE5.sh plasmashell (and only this process)
always ends up having the var set to an EMPTY string (I check this via /proc/PIC/environ).

I don't know from where RendererSettings is initialized, but I assume that the QString inside it is
not null but empty, so isNull() == false but isEmpty() == true

With this patch, QSG_RENDER_LOOP=basic is now correct in plasmashell's env after a login.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.Jul 26 2017, 9:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 26 2017, 9:15 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
davidedmundson accepted this revision.Jul 26 2017, 10:50 PM
This revision is now accepted and ready to land.Jul 26 2017, 10:50 PM
This revision was automatically updated to reflect the committed changes.