Make the editor more resilient to spurious trims
ClosedPublic

Authored by ervin on Dec 23 2015, 10:27 PM.

Details

Summary

It turns out that not only KMime trims the text or the title on some
condition. There's apparently some weird interaction I can't pin point
between akonadi and kcalcore serialization formats which lead to space
trims at the end of title or text.

So instead of purely comparing the last known strings and the new ones,
we are more lax with a regexp allowing whitespaces differences at the
end of title and the end of text.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 1604.Dec 23 2015, 10:27 PM
ervin retitled this revision from to Make the editor more resilient to spurious trims.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot.
ervin updated this revision to Diff 1606.Dec 23 2015, 10:46 PM

Cosmetic change to the regexp

bensi accepted this revision.Dec 24 2015, 12:42 PM
bensi edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 12:42 PM
This revision was automatically updated to reflect the committed changes.