Avoid leaking symbols of "pimpl" classes/structs
ClosedPublic
Actions

Authored by kossebau on Jul 26 2017, 12:17 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Nested classes/structs inherit the symbols visibility, so use
unnested ones

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

PS: I don't mind changing every struct to a class either, for consistency reasons.

This revision is now accepted and ready to land.Jul 26 2017, 7:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			interfaces/ibuddydocumentfinder.h (3 lines)
M			interfaces/ibuddydocumentfinder.cpp (9 lines)
M			language/assistant/staticassistantsmanager.h (4 lines)
M			language/assistant/staticassistantsmanager.cpp (17 lines)
M			language/duchain/duchaindumper.h (5 lines)
M			language/duchain/duchaindumper.cpp (13 lines)
M			project/abstractfilemanagerplugin.h (7 lines)
M			project/abstractfilemanagerplugin.cpp (28 lines)
M			project/projectfiltermanager.h (4 lines)
M			project/projectfiltermanager.cpp (11 lines)
M			shell/runcontroller.h (2 lines)
M			shell/runcontroller.cpp (2 lines)
M			util/projecttestjob.h (5 lines)
M			util/projecttestjob.cpp (11 lines)
M			vcs/vcspluginhelper.h (2 lines)
M			vcs/vcspluginhelper.cpp (26 lines)