Differential D6922

Avoid duplicated tasks in Workday page
ClosedPublic
Actions

Authored by ervin on Jul 26 2017, 10:11 AM.

Details

Reviewers
dfaure
bensi
franckarrecot
Commits
R4:772137c19adc: Avoid duplicated tasks in Workday page
Summary

We now use the cache in order to check if a task supposed to be in the
workday has a parent in the workday. In that case we don't need it as
top level since it'll be brought up again by its parent.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Jul 26 2017, 10:11 AM
bensi accepted this revision.Jul 30 2017, 8:26 AM
This revision is now accepted and ready to land.Jul 30 2017, 8:26 AM
dfaure added inline comments.Aug 2 2017, 7:34 AM
tests/units/akonadi/akonaditaskqueriestest.cpp
1612

wrong grammar

ervin updated this revision to Diff 17600.Aug 2 2017, 6:47 PM

Addressing the grammar error dfaure spotted

dfaure accepted this revision.Aug 2 2017, 8:41 PM
Closed by commit R4:772137c19adc: Avoid duplicated tasks in Workday page (authored by ervin). · Explain WhyAug 4 2017, 6:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17683

View Options

src/akonadi/akonaditaskqueries.cpp

Loading...
View Options

tests/units/akonadi/akonaditaskqueriestest.cpp

Loading...