We now use the cache in order to check if a task tagged with the current
context also has a parent tagged in that same context. In that case we
don't need it as top level since it'll be brought up again by its
parent.
Details
Details
Diff Detail
Diff Detail
- Repository
- R4 Zanshin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
tests/units/akonadi/akonadicontextqueriestest.cpp | ||
---|---|---|
272 | But if the first call to findTopLevelTasks returns garbage, we won't find out. Maybe this should be inside a for (int i = 0; i < 2; ++i) if you want to check that calling it twice works and returns the right result both times? (all the QCOMPARE and stuff being inside the for loop). | |
281 | Grammar error, I guess you meant "Should not change anything" |
tests/units/akonadi/akonadicontextqueriestest.cpp | ||
---|---|---|
272 | It's mainly about catching a crash we had way way back on the first queries we implemented. There are other tests where it's called only once so we'd know if that'd return garbage on the first try. |