Differential D6882

clazy fixes
ClosedPublic
Actions

Authored by vandenoever on Jul 24 2017, 4:09 PM.

Details

Reviewers

staniek

Group Reviewers

Calligra: 3.0

Summary

use Q_OBJECT
avoid detaching containers which leads to copying

Diff Detail

Repository

R8 Calligra

Lint

Lint Skipped

Unit

Unit Tests Skipped

vandenoever created this revision.Jul 24 2017, 4:09 PM

Good job!

This revision is now accepted and ready to land.Jul 24 2017, 8:12 PM

applied

Revision Contents
Changeset List

		Path
M		libs/flake/KoConnectionShapeFactory.h (1 line)
M		libs/flake/KoGradientBackground.cpp (2 lines)
M		libs/flake/KoHatchBackground.cpp (2 lines)
M		libs/flake/KoOdfGradientBackground.cpp (9 lines)
M		libs/flake/KoPathShapeFactory.h (1 line)
M		libs/flake/KoPatternBackground.cpp (4 lines)
M		libs/flake/KoResourceManager_p.cpp (1 line)
M		libs/flake/KoShape.cpp (6 lines)
M		libs/flake/KoShapeContainer.cpp (2 lines)
M		libs/flake/KoShapeGroup.cpp (4 lines)
M		libs/flake/KoShapeManager.cpp (2 lines)
M		libs/flake/KoShapeRegistry.cpp (2 lines)
M		libs/flake/KoToolBase.cpp (2 lines)
M		libs/flake/KoToolManager.cpp (6 lines)
M		libs/flake/commands/KoShapeReorderCommand.cpp (8 lines)
M		libs/flake/svg/SvgShapeFactory.h (1 line)
M		libs/flake/svg/SvgStyleWriter.cpp (1 line)
M		libs/flake/tests/TestKoShapeFactory.cpp (10 lines)
M		libs/flake/tests/TestSnapStrategy.cpp (6 lines)
M		libs/flake/tools/KoCreateShapesTool.h (1 line)
M		libs/flake/tools/KoPanTool.h (1 line)
M		libs/flake/tools/KoPathSegmentChangeStrategy.cpp (2 lines)
M		libs/flake/tools/KoPathTool.cpp (2 lines)
M		libs/flake/tools/KoZoomTool.h (1 line)
M		libs/kundo2/kundo2stack.h (1 line)
M		libs/kundo2/kundo2stack.cpp (2 lines)
M		libs/pigment/KoColorConversionSystem.cpp (2 lines)
M		libs/pigment/KoColorDisplayRendererInterface.h (1 line)
M		libs/pigment/KoColorSpace.cpp (4 lines)
M		libs/pigment/KoColorSpaceAbstract.h (2 lines)
M		libs/pigment/KoCompositeOpRegistry.h (2 lines)
M		libs/pigment/colorspaces/KoAlphaColorSpace.cpp (4 lines)
M		libs/pigment/tests/CCSGraph.cpp (4 lines)
M		libs/pigment/tests/TestColorConversionSystem.cpp (10 lines)
M		libs/pigment/tests/TestFallBackColorTransformation.cpp (2 lines)
M		libs/pigment/tests/TestKoColor.cpp (8 lines)
M		libs/plugin/KoPluginLoader.cpp (2 lines)
M		libs/text/BibliographyGenerator.cpp (2 lines)
M		libs/text/InsertNamedVariableAction_p.h (1 line)
M		libs/text/InsertTextLocator_p.h (1 line)
M		libs/text/InsertTextReferenceAction_p.h (1 line)
M		libs/text/InsertVariableAction_p.h (1 line)
M		libs/text/KoBibliographyInfo.cpp (4 lines)
M		libs/text/KoFindStrategy.cpp (2 lines)
M		libs/text/KoInlineCite.cpp (24 lines)
M		libs/text/KoNamedVariable.h (1 line)
M		libs/text/KoSectionModel.cpp (2 lines)
M		libs/text/KoTextDebug.cpp (1 line)
M		libs/text/KoTextEditor.cpp (2 lines)
M		libs/text/KoTextEditor_p.h (4 lines)
M		libs/text/KoTextReference.h (1 line)
M		libs/text/KoTextTableTemplate.h (1 line)
M		libs/text/OdfTextTrackStyles.h (2 lines)
M		libs/text/OdfTextTrackStyles.cpp (2 lines)
M		libs/text/changetracker/KoChangeTracker.cpp (2 lines)
M		libs/text/commands/DeleteTableColumnCommand.h (1 line)
M		libs/text/opendocument/KoTextLoader.cpp (2 lines)
M		libs/text/opendocument/KoTextWriter_p.cpp (6 lines)
M		libs/text/styles/KoCharacterStyle.cpp (6 lines)
M		libs/text/styles/KoParagraphStyle.cpp (2 lines)
M		libs/text/styles/tests/TestStyles.cpp (4 lines)
M		libs/text/tests/TestKoInlineTextObjectManager.h (1 line)
M		libs/text/tests/TestKoTextEditor.cpp (4 lines)
M		libs/textlayout/KoTextDocumentLayout.cpp (2 lines)
M		libs/textlayout/KoTextLayoutArea.cpp (2 lines)
M		libs/textlayout/KoTextShapeContainerModel.cpp (1 line)
M		libs/textlayout/tests/TestBlockLayout.cpp (3 lines)
M		libs/widgets/CMakeLists.txt (1 line)
M		libs/widgets/KoCsvImportDialog.cpp (4 lines)
M		libs/widgets/KoDocumentInfoDlg.cpp (2 lines)
M		libs/widgets/KoIconToolTip.h (2 lines)
M		libs/widgets/KoLineStyleItemDelegate_p.h (1 line)
M		libs/widgets/KoLineStyleModel_p.h (1 line)
M		libs/widgets/KoMarkerItemDelegate.h (1 line)
M		libs/widgets/KoMarkerModel.h (1 line)
M		libs/widgets/KoPositionSelector.cpp (2 lines)
M		libs/widgets/KoResourceItemDelegate.h (1 line)
M		libs/widgets/KoResourcePopupAction.cpp (2 lines)
M		libs/widgets/KoResourceServerProvider.cpp (6 lines)
M		libs/widgets/KoRuler_p.h (1 line)
M		libs/widgets/KoSliderCombo.cpp (16 lines)
M		libs/widgets/KoSliderCombo_p.h (17 lines)
M		libs/widgets/KoStrokeConfigWidget.cpp (2 lines)
M		libs/widgets/KoToolBox.cpp (4 lines)
M		libs/widgets/KoToolBoxLayout_p.h (10 lines)
A	M	libs/widgets/KoToolBoxLayout_p.cpp (27 lines)
M		libs/widgets/KoTriangleColorSelector.cpp (2 lines)
M		libs/widgets/tests/KoProgressUpdater_test.cpp (3 lines)
M		libs/widgets/tests/KoResourceTaggingTest.cpp (2 lines)
M		libs/widgets/tests/zoomhandler_test.cpp (8 lines)
M		libs/widgetutils/KoGroupButton.h (6 lines)
M		libs/widgetutils/KoGroupButton.cpp (2 lines)
M		libs/widgetutils/KoProperties.cpp (7 lines)