Replace SMTP KIO Slave with KSmtp library
ClosedPublic
Actions

Authored by dvratil on Jul 24 2017, 2:46 PM.

Details

Reviewers

mlaurent

Commits

R84:b2198b447ab2: Replace SMTP KIO Slave with KSMTP library

Summary

Use KSmtp library from the SMTP mail transport plugin instead of using a complex KIO slave.

Repository

R84 PIM: KMail Transport

Lint

Lint Skipped

Unit

Unit Tests Skipped

Hi,
make sure that we can send email with several smtp server :)

I will be off tomorrow until friday, so I hope that I will able to accept your patch :)

Regards.

src/kmailtransport/plugins/smtp/autotests/fakeserver.cpp
27	initialize m_tcpServer to nullptr
165	for(...: qAsConst(...))
src/kmailtransport/plugins/smtp/autotests/fakeserver.h
37	Q_decl_override here ? if necessary replace it by override
40	override

This revision now requires changes to proceed.Jul 24 2017, 3:22 PM

Seems ok for me.

This revision is now accepted and ready to land.Jul 27 2017, 5:02 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		CMakeLists.txt (2 lines)
M		src/kmailtransport/plugins/smtp/CMakeLists.txt (7 lines)
A	M	src/kmailtransport/plugins/smtp/autotests/CMakeLists.txt (19 lines)
A	M	src/kmailtransport/plugins/smtp/autotests/fakeserver.h (67 lines)
A	M	src/kmailtransport/plugins/smtp/autotests/fakeserver.cpp (231 lines)
A	M	src/kmailtransport/plugins/smtp/autotests/smtpjobtest.cpp (132 lines)
A	M	src/kmailtransport/plugins/smtp/sessionuiproxy.h (33 lines)
M		src/kmailtransport/plugins/smtp/smtpjob.h (8 lines)
M		src/kmailtransport/plugins/smtp/smtpjob.cpp (324 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17120			Jul 24 2017, 2:44 PM	★	★
Diff 2	17178			Jul 25 2017, 2:26 PM	★	★
Diff 3	17454	ecab7a6	R84:b2198b447ab2c4d048035aeacd71a8b05f3c53df	Jul 31 2017, 7:37 PM	★	★