Have Escape work from anywhere
ClosedPublic

Authored by ervin on Dec 22 2015, 11:04 PM.

Details

Summary

The action mapped on escape was scoped fairly strictly to only the
filter and quick add widgets. That was mainly to make sure that escape
would have a different behavior in the central view (clear the
selection). Alas, we'd like the action behavior everywhere in the
application so that escape always gets you back to the central view.

The solution is simply to have the action triggerable from anywhere, but
to make sure it's properly enabled/disabled when the central view
gets/looses the focus.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 1575.Dec 22 2015, 11:04 PM
ervin retitled this revision from to Have Escape work from anywhere.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot, dfaure.
bensi accepted this revision.Dec 23 2015, 10:28 AM
bensi edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 10:28 AM
This revision was automatically updated to reflect the committed changes.