Differential D6706

Fix empty string when change the Proxy SOCKS address
Needs RevisionPublic
Actions

Authored by dmariano on Jul 14 2017, 6:50 PM.

Details

Reviewers
dfaure
Summary

The url of the field "Proxy SOCKS:" is not restored to the QLineEdit when the Proxy program is reopened.
The problem is if the variable "Qurl url" doesn't have a scheme, host() returns a empty string. Hope this helps.

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
dmariano created this revision.Jul 14 2017, 6:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 14 2017, 6:50 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dmariano retitled this revision from Empty string when change the Proxy address to Fix empty string when change the Proxy SOCKS address.Jul 14 2017, 6:52 PM
dfaure requested changes to this revision.Aug 4 2017, 7:51 PM
dfaure added a subscriber: dfaure.

Urls without schemes shouldn't really happen, so this fix doesn't make me too happy. I debugged this KCM a bit and it seems the issue is the commit that prepends a scheme (like socks://) which interfers with the assumption that after the first ':' comes the port.
The KCM works for me with this alternative fix, can you test?

https://phabricator.kde.org/D7142

This revision now requires changes to proceed.Aug 4 2017, 7:51 PM

Revision Contents
Changeset List

PathPackages
Msrc/kcms/kio/kproxydlg.cpp (6 lines)

Diff 16721

View Options

src/kcms/kio/kproxydlg.cpp

Loading...