Fix flickering of imageViewer
ClosedPublic
Actions

Authored by atulsharma on Jul 14 2017, 4:11 PM.

Details

Reviewers

mart

Group Reviewers

Koko

Maniphest Tasks

Commits

R659:6adbb0e2f9ef: Fix flickering of imageViewer

Summary

If a command line image is passed it first showed the alumview and then flickers to show imageviewer
this patch allows to show imageviewer in case an image is given

Repository

R659 Koko Image Gallery

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mart requested changes to this revision.Jul 14 2017, 5:02 PM

mart added inline comments.

src/imagefoldermodel.h
74 ↗	(On Diff #16712)	again, you don't need to add new signals, just set the predefined state in ImageViewer like state: imagePathArgument != "" ? "open" : "closed"

This revision now requires changes to proceed.Jul 14 2017, 5:02 PM

Changes a little bit of implementation to set the directoryPath to ~/Pictures later

This revision is now accepted and ready to land.Jul 14 2017, 5:42 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			qmlUiKirigami/ImageViewer.qml (1 line)
M			qmlUiKirigami/Main.qml (2 lines)
M			src/imagefoldermodel.cpp (10 lines)
M			src/main.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16712	58a21b1		Jul 14 2017, 4:11 PM	★	★
Diff 2	16714	58a21b1	Changes a little bit of implementation to set the directoryPath to ~/Pictures…	Jul 14 2017, 5:39 PM	★	★
Diff 3	16715	58a21b1	R659:6adbb0e2f9ef9413721b62d3216a42f3a5cb99d8	Jul 14 2017, 5:43 PM	★	★