Make it an int option that denote an index of selected generator in static generators list.
Details
Details
- Reviewers
kfunk - Group Reviewers
KDevelop - Commits
- R32:c5fde22d1de6: Fix default CMake generator setting.
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good to me in general.
Please add BUG: 356875 to commit message.
| projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp | ||
|---|---|---|
| 46–47 | Prefer foreach on Qt containers. (Details: http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/) | |
| 46–47 | Style: const QString&, same in other locations | |
| 55 | I think you can remove the default, apply, reset overrides here now completely(?) | |
| projectbuilders/cmakebuilder/cmakebuilder.h | ||
|---|---|---|
| 63 | Style: Return QStringList by value (default style with implicitly shared types, such as QList) | |
Comment Actions
Another find, sorry.
| projectbuilders/cmakebuilder/cmakebuilder.cpp | ||
|---|---|---|
| 84 | Hm. And move that to supportedGenerators function. Remove the static generatorNames variable. Hint: You'd add *new* items each time the CMakeBuilder ctor runs (plugin might be unloaded + loaded again). | |
Comment Actions
Don't fill generatorNames multiple times.
Remove overrides in CMakeBuilderPreferences.
Style fixes.