Select default make tool based on which platform we are, not the compiler we using. On windows first try "make" (extremely rare), then "mingw32-make" and then "nmake". Fix typo in method name.
Details
Details
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Branch
- 5.0
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Looks good to me in general. +1.
| projectbuilders/makebuilder/makebuilderpreferences.cpp | ||
|---|---|---|
| 81 | Nitpick: if ( foo ) -> if (foo) | |
| projectbuilders/makebuilder/makejob.cpp | ||
| 186 | Let's factor the makeBin != ... out in some free bool isUnixMake(const QString& makeBin) function. Also: makeBin could be a fully-qualified path, protect against this. | |
Comment Actions
Just noticed: /N and /K are valid arguments to nmake, so it'd make sense to pass them instead of the Unix Make counterparts -n and -k.
Example:
if ( ! builderGroup.readEntry("Abort on First Error", true)) {
cmdLine << (isUnixMake(...) ? "-k" : "/K");
}Also see: https://msdn.microsoft.com/en-us/library/afyyse50.aspx