Differential D664

DUChain: Remove duplicates inside getInheriters
ClosedPublic
Actions

Authored by kfunk on Dec 17 2015, 11:12 PM.

Details

Reviewers
mwolff
Commits
R33:de846fccab42: Revert "IndexedString::toUrl: Fix too-strict assert"
R33:11b8336ae438: DUChain: Remove duplicates inside getInheriters
R32:7db4150e5425: DUChain: Remove duplicates inside getInheriters
R32:de846fccab42: Revert "IndexedString::toUrl: Fix too-strict assert"
R33:7db4150e5425: DUChain: Remove duplicates inside getInheriters
R32:11b8336ae438: DUChain: Remove duplicates inside getInheriters
Summary

Example navigation popup before:

Inheritors for AbstractDeclarationNavigationContext:
DeclarationNavigationContext, CMakeDeclarationNavigationContext, QmlJS::DeclarationNavigationContext,
DeclarationNavigationContext

After:

Inheritors for AbstractDeclarationNavigationContext:
CMakeDeclarationNavigationContext, QmlJS::DeclarationNavigationContext,
DeclarationNavigationContext

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk updated this revision to Diff 1548.Dec 17 2015, 11:12 PM
kfunk retitled this revision from to DUChain: Remove duplicates inside getInheriters.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 17 2015, 11:12 PM
kfunk added a comment.Dec 17 2015, 11:14 PM

Does the job, but I'm happy to be convinced by better solutions.

mwolff accepted this revision.Dec 19 2015, 12:12 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

+1,the list is usually small and the order is unimportant, so having it sorted and having duplicates removed sounds like a good idea to me.

This revision is now accepted and ready to land.Dec 19 2015, 12:12 PM
Closed by commit R33:11b8336ae438: DUChain: Remove duplicates inside getInheriters (authored by kfunk). · Explain WhyDec 19 2015, 1:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlanguage/duchain/duchainutils.cpp (16 lines)

Diff 1552

View Options

language/duchain/duchainutils.cpp

Loading...