SharePlugin refactoring
ClosedPublic
Actions

Authored by nicolasfella on Jul 10 2017, 6:46 PM.

Details

Reviewers

albertvaka

Group Reviewers

KDE Connect

Commits

R225:45f3311b70ba: SharePlugin refactoring

Summary

Some refactoring in the Shareplugin:

Extracted some parts into separate methods
Extracted notification into separate class
Some optical tweaks on notifications

Repository

R225 KDE Connect - Android application

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Looks much better! Ship it!

src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java
258 ↗	(On Diff #16467)	It seems that the successful variable is not needed, you can pass false to setFinished when called from within the 'catch' block.

This revision is now accepted and ready to land.Jul 10 2017, 10:15 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		.gitignore (1 line)
M		build.gradle (2 lines)
M		src/org/kde/kdeconnect/Plugins/SharePlugin/NotificationUpdateCallback.java (3 lines)
A	M	src/org/kde/kdeconnect/Plugins/SharePlugin/ShareNotification.java (104 lines)
M		src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java (334 lines)