Differential D6613

SharePlugin refactoring
ClosedPublic
Actions

Authored by nicolasfella on Jul 10 2017, 6:46 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:45f3311b70ba: SharePlugin refactoring
Summary

Some refactoring in the Shareplugin:

Extracted some parts into separate methods
Extracted notification into separate class
Some optical tweaks on notifications

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 10 2017, 6:46 PM
albertvaka added a subscriber: albertvaka.Jul 10 2017, 10:14 PM

Looks much better! Ship it!

src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java
258

It seems that the successful variable is not needed, you can pass false to setFinished when called from within the 'catch' block.

albertvaka accepted this revision.Jul 10 2017, 10:15 PM
This revision is now accepted and ready to land.Jul 10 2017, 10:15 PM
Closed by commit R225:45f3311b70ba: SharePlugin refactoring (authored by nicolasfella). · Explain WhyJul 11 2017, 8:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16494

View Options

.gitignore

Loading...
View Options

build.gradle

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/NotificationUpdateCallback.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/ShareNotification.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java

Loading...