Differential D652

Workaround broken fetch items based on their tag
ClosedPublic
Actions

Authored by ervin on Dec 11 2015, 4:42 PM.

Details

Reviewers
bensi
dvratil
franckarrecot
Commits
R4:c1e8c775abe9: Workaround broken fetch items based on their tag
Summary

It turns out that FetchItemJob for tag contexts doesn't list us the
tagged items properly... until the tagged item has been fetched by
another unrelated job. It obviously create weird issues which are hard
to reproduce in tests (I didn't manage to isolate a unit test at least).

It seems to be fixed in akonadi/qt5 if I trust git log there.

For the time being, work around that issue with a super-inefficient
implementation in our help functions. We fetch all items and trash the
ones which don't have the tag we're looking for.

Clearly something to remove and reevaluate once we port to Qt5.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 1503.Dec 11 2015, 4:42 PM
ervin retitled this revision from to Workaround broken fetch items based on their tag.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot, dvratil.
bensi accepted this revision.Dec 11 2015, 4:59 PM
bensi edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2015, 4:59 PM
Closed by commit R4:c1e8c775abe9: Workaround broken fetch items based on their tag (authored by ervin). · Explain WhyDec 11 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1505

View Options

src/akonadi/akonadilivequeryhelpers.cpp

Loading...