Created a beta version of the guitar.
Implemented just the visuals. Waiting for review to continue
Details
Details
- Reviewers
sandroandrade
Diff Detail
Diff Detail
- Repository
- R163 Minuet
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Hi,
Some suggestions before diving into code:
- Please use "Fret" rather than "Octave" in guitar. I'm still unsure if we'd need to show "Fret" in every position.
- Although is some obvious, it'd be nice to have a different representation for the nut, on the left.
- I'd add also the small circles usually placed on frets 3, 5, 7, 9, 12 (double circles here), 15, 17. That helps a lot to identify positions. See http://www.stringswork.com/wp-content/uploads/Parts-of-a-guitar.jpg.
Let's finish this patch and consider it only for the visual representation and then move into notes and chords visualization functionalities.
Comment Actions
Also, I'd expect this patch to be applicable into the gsoc2017 branch, containing only the new things you have made. It doesn't apply in such a branch.
Comment Actions
All points are covered:
- representation for the nut, on the left
- representation for the circle markers 3, 5, 7...
- the patch is now applied directly on top of the "gsoc2017" branch
+ some typo revisions: removed unnecessary spaces