Differential D647

Improve LoadCorruptQuery messagebox
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 9 2015, 11:00 PM.

Details

Reviewers
rthomsen
Commits
R36:d56d0061e4dc: Improve usability of LoadCorruptQuery messagebox
Summary

The current messagebox text is a bit too verbose.
This patch simplify it by moving the two possible outcomes in the buttons,
replacing Yes and No.

Test Plan

The query still works.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 1494.Dec 9 2015, 11:00 PM
elvisangelaccio retitled this revision from to Improve LoadCorruptQuery messagebox.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio updated this object.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptDec 9 2015, 11:00 PM
rthomsen requested changes to this revision.Dec 10 2015, 6:07 AM
rthomsen edited edge metadata.
rthomsen added inline comments.
kerfuffle/queries.cpp
221–222

Shouldn't the button texts be translated?

This revision now requires changes to proceed.Dec 10 2015, 6:07 AM
elvisangelaccio updated this revision to Diff 1496.Dec 10 2015, 9:33 AM
elvisangelaccio edited edge metadata.
  • Translate also buttons' text
elvisangelaccio marked an inline comment as done.Dec 10 2015, 9:34 AM

Translate also the text in the buttons.

rthomsen accepted this revision.Jan 1 2016, 12:16 PM
rthomsen edited edge metadata.

Ship it! :)

This revision is now accepted and ready to land.Jan 1 2016, 12:16 PM
Closed by commit R36:d56d0061e4dc: Improve usability of LoadCorruptQuery messagebox (authored by elvisangelaccio). · Explain WhyJan 2 2016, 10:21 AM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:d56d0061e4dc: Improve usability of LoadCorruptQuery messagebox.

Revision Contents
Changeset List

PathPackages
Mkerfuffle/queries.cpp (9 lines)

Diff 1698

View Options

kerfuffle/queries.cpp

Loading...