Differential D646

Introduce KNewPasswordWidget in CreateDialog
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 9 2015, 10:15 PM.

Details

Reviewers
rthomsen
Commits
R36:923f8185013d: CreateDialog: port to KNewPasswordWidget
Summary

This bumps the KF5 requirements to 5.16.

Test Plan

Creating a password-protected archive still works.
If the passwords are empty or do not match, a warning is displayed.

Diff Detail

Repository
R36 Ark
Branch
refactor/knewpasswordwidget
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 1493.Dec 9 2015, 10:15 PM
elvisangelaccio retitled this revision from to Introduce KNewPasswordWidget in CreateDialog.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio updated this object.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptDec 9 2015, 10:15 PM
rthomsen accepted this revision.Jan 4 2016, 7:34 PM
rthomsen edited edge metadata.
rthomsen added inline comments.
kerfuffle/createdialog.cpp
145 ↗(On Diff #1493)

Delete "chosen" here.

This revision is now accepted and ready to land.Jan 4 2016, 7:34 PM
elvisangelaccio updated this revision to Diff 1734.Jan 4 2016, 10:12 PM
elvisangelaccio edited edge metadata.
  • Merge branch 'master' into refactor/knewpasswordwidget
  • Improve i18n message
elvisangelaccio marked an inline comment as done.Jan 4 2016, 10:13 PM

Fixed the message for empty passwords.

Closed by commit R36:923f8185013d: CreateDialog: port to KNewPasswordWidget (authored by elvisangelaccio). · Explain WhyFeb 10 2016, 10:43 AM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:923f8185013d: CreateDialog: port to KNewPasswordWidget.

Revision Contents
Changeset List

Diff 1734

View Options

CMakeLists.txt

Loading...
View Options

kerfuffle/createdialog.h

Loading...
View Options

kerfuffle/createdialog.cpp

Loading...
View Options

kerfuffle/createdialog.ui

Loading...