Differential D6433

Hide qt_check_for_QGADGET_macro() from autocompletion
ClosedPublic
Actions

Authored by dvratil on Jun 29 2017, 2:28 PM.

Details

Reviewers
brauch
Group Reviewers
KDevelop
Commits
R32:3a9617e025fc: Hide qt_check_for_QGADGET_macro() from autocompletion
R32:fe2cfb81e3fc: Hide qt_check_for_QGADGET_macro() from autocompletion
Summary

Hide qt_check_for_QGADGET_macro() generated by Q_GADGET macro the same way we hide qt_metacall() and similar methods produced by the Q_OBJECT macro.

Q_GADGET also defines typedef void QtGadgetHelper, but that might actually be useful to application developers to detect when dealing with a
gadgets at compile time so I did not hide it.

Test Plan

qt_check_for_QGADGET_macro() no longer appears in autocompletion when Q_GADGET macro is present in a class.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Jun 29 2017, 2:28 PM
brauch accepted this revision.Jun 29 2017, 4:22 PM
brauch added a subscriber: brauch.

LGTM, thanks!

This revision is now accepted and ready to land.Jun 29 2017, 4:22 PM
Closed by commit R32:fe2cfb81e3fc: Hide qt_check_for_QGADGET_macro() from autocompletion (authored by dvratil). · Explain WhyJun 29 2017, 6:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16027

View Options

languages/clang/codecompletion/completionhelper.cpp

Loading...