Differential D6366

Fix configure with Qt5Multimedia disabled.
ClosedPublic
Actions

Authored by palimaka on Jun 24 2017, 4:50 AM.

Details

Reviewers
mgallien
Group Reviewers
Frameworks
Commits
R286:f30fede21bf0: Fix configure with Qt5Multimedia disabled.
Summary

When passed -DBUILD_TESTING=OFF -DCMAKE_DISABLE_FIND_PACKAGE_Qt5Multimedia=ON,
CMake failed because find_package(Qt5 COMPONENTS MULTIMEDIA) was treated as
required due to the previous find_package(Qt5 REQUIRED COMPONENTS Xml) call.

Finding Qt5Multimedia directly via its own config file ensures that it really
is treated as optional.

Test Plan

Configures and builds both with and without Qt5Multimedia enabled.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
palimaka created this revision.Jun 24 2017, 4:50 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 24 2017, 4:50 AM
mgallien accepted this revision.Jun 24 2017, 3:55 PM
mgallien added a subscriber: mgallien.

Thanks for the help.
I did not knew this could be wrong.

This revision is now accepted and ready to land.Jun 24 2017, 3:55 PM
Closed by commit R286:f30fede21bf0: Fix configure with Qt5Multimedia disabled. (authored by palimaka). · Explain WhyJun 24 2017, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 15821

View Options

CMakeLists.txt

Loading...