Differential D634

Fix rare cases when rangeForIncludeSpec() wasn't working correctly.
ClosedPublic
Actions

Authored by arrowd on Dec 6 2015, 4:53 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Summary

This is patch from https://git.reviewboard.kde.org/r/122798 with unit tests.

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
arrowd updated this revision to Diff 1460.Dec 6 2015, 4:53 PM
arrowd retitled this revision from to Fix rare cases when rangeForIncludeSpec() wasn't working correctly..
arrowd updated this object.
arrowd edited the test plan for this revision. (Show Details)
arrowd added a reviewer: KDevelop.
arrowd set the repository for this revision to R32 KDevelop.
arrowd added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 6 2015, 4:53 PM
kfunk added a subscriber: kfunk.Dec 7 2015, 9:05 AM

Rest LGTM, thanks!

languages/clang/tests/test_clangutils.cpp
218

Use QCOMPARE(actual, expected)

kfunk accepted this revision.Dec 7 2015, 12:47 PM
kfunk added a reviewer: kfunk.
This revision is now accepted and ready to land.Dec 7 2015, 12:47 PM

Revision Contents
Changeset List

Diff 1460

View Options

languages/clang/clangsupport.cpp

Loading...
View Options

languages/clang/tests/test_clangutils.h

Loading...
View Options

languages/clang/tests/test_clangutils.cpp

Loading...
View Options

languages/clang/util/clangutils.h

Loading...
View Options

languages/clang/util/clangutils.cpp

Loading...