Differential D6326

[kcalc] Do not group leading sign character
ClosedPublic
Actions

Authored by cfeck on Jun 21 2017, 8:52 PM.

Details

Reviewers
teran
Commits
R353:50cfdbb7703a: Fix grouping display with negative numbers
Summary

A negative sign was included into counting digit groups:

9999 grouped as 9,999
-9999 grouped as -9,999
999 grouped as 999
-999 grouped as -,999

The bug is with the last number.

This fixes https://bugs.kde.org/show_bug.cgi?id=381418

Test Plan

Tested steps from bug 381418.

Diff Detail

Repository
R353 KCalc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.Jun 21 2017, 8:52 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJun 21 2017, 8:52 PM
cfeck updated this revision to Diff 15714.Jun 21 2017, 8:56 PM

Use QString::length() instead of QString::size() for consistency.

teran accepted this revision.Jun 21 2017, 9:12 PM

Looks good to me, thanks!

This revision is now accepted and ready to land.Jun 21 2017, 9:12 PM
ltoscano added a subscriber: ltoscano.Jun 21 2017, 10:07 PM

Remember to use the BUG: syntax in the commit message!

Closed by commit R353:50cfdbb7703a: Fix grouping display with negative numbers (authored by cfeck). · Explain WhyJun 22 2017, 4:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcalcdisplay.cpp (11 lines)

Diff 15750

View Options

kcalcdisplay.cpp

Loading...