Differential D6300

Introduce kmm_csvimport_core
ClosedPublic
Actions

Authored by wojnilowicz on Jun 20 2017, 2:53 PM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:2eea9cee9160: Introduce kmm_csvimport_core

Summary

Purpose of this patch is to get rid of kmm_csvimport_static.
Advantages:

no bulky kmm_csvimport_static,
test cases can use kmm_csvimport_core directly,
CSV importer is even more separate from CSV wizard than before,
webpricequote update now can link only to CSV importer without

wizard,

webpricequote and CSV Wizard use the same binary (i.e. shared

library),

kmymoney binary + shared library + plugin library is about 15 MB

smaller, than before.

Diff Detail

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz created this revision.Jun 20 2017, 2:53 PM

new csvenums.h which helps setting profiles for webpricequote.
CSV Importer needs no kmymoney_common module
MyMoneyQifReader::checkCategory and CsvUtil::checkCategory have been deduplicated and put into mymoneyfile.cpp; KMyMoneyApp::createAccount follows and fits "almost perfectly" in mymoneyfile.cpp.
csvutil.cpp and convdate.cpp has been rewritten and cleaned up - lots of redundant code.

Other than that it looks clean to me (have not compiled nor run it)

kmymoney/mymoney/mymoneyfile.cpp
939	Code from MyMoneyFile downwards to the storage should not have UI relevant code. Please extract it here and provide external method to do that or check and modify in the calling method.

This revision now requires changes to proceed.Jul 6 2017, 11:37 AM

wojnilowicz abandoned this revision.Jul 6 2017, 4:28 PM

Closed by commit R261:2eea9cee9160: Introduce kmm_csvimport_core (authored by wojnilowicz). · Explain WhyJul 16 2017, 6:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kmymoney/converter/CMakeLists.txt (2 lines)
M		kmymoney/converter/mymoneyqifreader.h (16 lines)
M		kmymoney/converter/mymoneyqifreader.cpp (73 lines)
M		kmymoney/converter/webpricequote.cpp (41 lines)
M		kmymoney/dialogs/settings/ksettingsonlinequotes.cpp (8 lines)
M		kmymoney/kmymoney.cpp (75 lines)
M		kmymoney/mymoney/mymoneyfile.h (17 lines)
M		kmymoney/mymoney/mymoneyfile.cpp (139 lines)
M		kmymoney/plugins/CMakeLists.txt (2 lines)
M		kmymoney/plugins/csvimport/CMakeLists.txt (37 lines)
M		kmymoney/plugins/csvimport/bankingwizardpage.h (18 lines)
M		kmymoney/plugins/csvimport/bankingwizardpage.cpp (171 lines)
M		kmymoney/plugins/csvimport/convdate.h (26 lines)
M		kmymoney/plugins/csvimport/convdate.cpp (88 lines)
A	M	kmymoney/plugins/csvimport/csvenums.h (35 lines)
M		kmymoney/plugins/csvimport/csvimporter.h (120 lines)
M		kmymoney/plugins/csvimport/csvimporter.cpp (508 lines)
M		kmymoney/plugins/csvimport/csvimporterplugin.h (2 lines)
M		kmymoney/plugins/csvimport/csvimporterplugin.cpp (14 lines)
M		kmymoney/plugins/csvimport/csvutil.h (96 lines)
M		kmymoney/plugins/csvimport/csvutil.cpp (588 lines)
M		kmymoney/plugins/csvimport/csvwizard.h (195 lines)
M		kmymoney/plugins/csvimport/csvwizard.cpp (284 lines)
A	M	kmymoney/plugins/csvimport/csvwizardpage.h (36 lines)
M		kmymoney/plugins/csvimport/formatswizardpage.ui (6 lines)
M		kmymoney/plugins/csvimport/investmentwizardpage.h (19 lines)
M		kmymoney/plugins/csvimport/investmentwizardpage.cpp (210 lines)
M		kmymoney/plugins/csvimport/priceswizardpage.h (16 lines)
M		kmymoney/plugins/csvimport/priceswizardpage.cpp (73 lines)
M		kmymoney/plugins/csvimport/tests/CMakeLists.txt (3 lines)
M		kmymoney/plugins/csvimport/tests/csvdate-test.cpp (6 lines)
M		kmymoney/plugins/csvimport/tests/parsedata-test.cpp (6 lines)
M		kmymoney/plugins/csvimport/tests/symbol-test.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15649			Jun 20 2017, 2:52 PM	★	★
Diff 2	16122			Jul 3 2017, 11:04 AM	★	★
Diff 3	16784	2524dbb	R261:2eea9cee9160ae12af1335c2d56e5d879e2cc632	Jul 6 2017, 4:17 PM	★	★