Avoid resize on showing notificaton item
AbandonedPublic

Authored by davidedmundson on Jun 16 2017, 2:04 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary

The notification dialog height is based on the implicit height of
mainLayout. Main layout would shift depending on whether we were showing
the icon on the left.

When we hide a dialog we set the root item to invisible, this changes
the effective visibility of these images, which in turn changes the
width of the main layout and therefore the implicit height.

This patch changes comparing visibility of the icon to comparing if it's
null which is persistent.

Test Plan

Showed an notification
Confirmed the implicitHeight stayed the same in gammaray

Tested both with a KDE notification with an icon and notify-send

Marco can you see if it helps your issue, without the part of
your p-f patch that changes rootItem visibility.

Diff Detail

Repository
R120 Plasma Workspace
Branch
Plasma/5.10
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Jun 16 2017, 2:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 16 2017, 2:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jun 16 2017, 2:08 PM
This revision is now accepted and ready to land.Jun 16 2017, 2:08 PM
davidedmundson abandoned this revision.Jun 19 2017, 9:59 AM

Code is now in D6216